Skip to content

Conversation

@XComp
Copy link
Contributor

@XComp XComp commented Mar 14, 2022

This is a 1.14 backport of PR #19066

What is the purpose of the change

If the ZK connection is flaky, we might collect another
ZK connection loss. This is now handled properly.

Brief change log

  • Adds null check to condition

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@XComp XComp changed the title [FLINK-26596][runtime][test] Adds leadership loss handling [FLINK-26596][BP-1.14][runtime][test] Adds leadership loss handling Mar 14, 2022
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@XComp
Copy link
Contributor Author

XComp commented Mar 15, 2022

Errors in ci run are unrelated:

If the ZK connection is flaky, we might collect another
ZK connection loss. This is now handled properly.
@XComp XComp force-pushed the FLINK-26596-bp-1.14 branch from 8e513a6 to 749c4b3 Compare March 15, 2022 07:40
@XComp
Copy link
Contributor Author

XComp commented Mar 15, 2022

rebased release-1.14 after the FLINK-26121 backport PR was merged

@XComp
Copy link
Contributor Author

XComp commented Mar 16, 2022

Test failure resulted due an internal error when publishing build artifacts. Unrelated to the change. No ticket created because there are plans to switch to GHA anyway

@XComp XComp merged commit 143f8e0 into apache:release-1.14 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants