Skip to content

Conversation

@Myracle
Copy link
Contributor

@Myracle Myracle commented Mar 17, 2022

What is the purpose of the change

Modify the grammar mistakes in savepoints.md

Brief change log

  • Change the sentence "The legacy is mode is how Flink worked until 1.15." to "The legacy mode is how Flink worked until 1.15."

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

XComp and others added 12 commits March 15, 2022 08:07
…lelism

The deadline of 10s wasn't sufficient enough for AzureCI runs.
Remove planner&executor string identifiers from `EnvironmentSettings`
and use the default strings which are only used anyway.
Those 2 methods accept also a TableConfig, which is not necessary,
since with the new approach, extra configuration will be passed through
`EnvironmentSettings` instead. If those methods are still around will
create confusion.
Use `EnvironmentSettings` with the new method `withConfiguration` in its
`Builder` to specify configuration options on top of the one inherited
by the environment (flink-conf.yml, CLI params).

The `TableConfig` contains all of the config options specified by the env
(flink-conf.yml, CLI params) + all the extra configuration defined by the
user app through the `EnvironmentSettings`.
Since each test uses a separate table we no longer need to re-create the keyspace for each run, reducing the load on the cluster.
Some InternalPriorityQueue implementations need a correct key/group
set before performing poll() or remove().

In particular, ChangelogKeyGroupedPriorityQueue logs key group so that
state changes can be re-distributed or shuffled.

This change re-orders queue.poll and keyContext.setCurrentKey.
Implements the SEARCH operator in the codegen and removes
the scalar implementation of IN and NOT_IN. Now every scalar
IN/NOT_IN using a constant set is implemented through SEARCH
(following Calcite's development on the topic CALCITE-4173)
and plans will only have SEARCH.

This closes apache#19001.
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Myracle Myracle changed the title Flink 26693 modify the grammar mistakes in savepoints.md [FLINK-26693][Documentation] Modify the grammar mistakes in savepoints.md Mar 17, 2022
@Myracle Myracle closed this Mar 17, 2022
@Myracle Myracle deleted the FLINK-26693-Modify-the-grammar-mistakes-in-savepoints.md branch March 17, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.