Skip to content

Conversation

@masteryhx
Copy link
Contributor

What is the purpose of the change

Add discussion about whether it is safe to reuse objects for different state backends to state backend docs.

Brief change log

  • Add discussion in The HashMapStateBackend and The EmbeddedRocksDBStateBackend of state_backends.md.

Verifying this change

This change is trivial without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR. I think we also need to update related chinese documentation.

@masteryhx
Copy link
Contributor Author

Thanks for creating the PR. I think we also need to update related chinese documentation.

Thanks for the remind. I have also updated the related chinese documentation.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@Myasuka Myasuka closed this in 4175fef Mar 21, 2022
Myasuka pushed a commit that referenced this pull request Mar 21, 2022
Myasuka pushed a commit that referenced this pull request Mar 21, 2022
JasonLeeCoding pushed a commit to JasonLeeCoding/flink that referenced this pull request May 27, 2022
zstraw pushed a commit to zstraw/flink that referenced this pull request Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants