Skip to content

Conversation

@zoucao
Copy link
Contributor

@zoucao zoucao commented Mar 18, 2022

What is the purpose of the change

fix the error message thrown by SourceCoordinatorContext

Brief change log

fix the error message SourceCoordinatorContext
provide more message for test in SourceCoordinatorContextTest

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@zoucao
Copy link
Contributor Author

zoucao commented Mar 18, 2022

@flinkbot run azure

@zoucao
Copy link
Contributor Author

zoucao commented Mar 18, 2022

Gentle ping @becketqin, could you help me to review this pr in your spare time ?

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zoucao
Copy link
Contributor Author

zoucao commented Mar 19, 2022

@flinkbot run azure

@becketqin
Copy link
Contributor

LGTM. The CI failure should be irrelevant to this PR.

@becketqin becketqin merged commit da79677 into apache:master Mar 20, 2022
@becketqin
Copy link
Contributor

Merged to master: da79677
Cherry-picked to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants