[FLINK-26770][table] Fix ArrayToArrayCastRule array type #19188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
Contributor
Author
|
We should backport this to 1.15 branch as well |
Collaborator
wenlong88
reviewed
Mar 22, 2022
| return CodeGenUtils.boxedTypeTermForType(t); | ||
| } | ||
| switch (t.getTypeRoot()) { | ||
| case BOOLEAN: |
Contributor
There was a problem hiding this comment.
hi, I think it would be better to use CodeGenUtils.primitiveTypeTermForType instead, what do you think?
Maybe we need to check isPrimitiveNullable first when t is nullable, if it is true, we should use primitiveType instead of boxedType.
Contributor
Author
There was a problem hiding this comment.
I pushed a change, also adding another test to make sure this works. Does it looks good now?
Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
wenlong88
reviewed
Mar 22, 2022
Contributor
wenlong88
left a comment
wenlong88
left a comment
There was a problem hiding this comment.
thanks for the update, I left a few more comment.
...ner/src/main/java/org/apache/flink/table/planner/functions/casting/ArrayToArrayCastRule.java
Show resolved
Hide resolved
...le-planner/src/test/java/org/apache/flink/table/planner/functions/casting/CastRulesTest.java
Show resolved
Hide resolved
cun8cun8
pushed a commit
to cun8cun8/flink
that referenced
this pull request
Mar 28, 2022
…ucture This closes apache#19188.
cun8cun8
pushed a commit
to cun8cun8/flink
that referenced
this pull request
Mar 28, 2022
…ucture This closes apache#19188.
cun8cun8
pushed a commit
to cun8cun8/flink
that referenced
this pull request
Mar 28, 2022
…ucture This closes apache#19188.
JasonLeeCoding
pushed a commit
to JasonLeeCoding/flink
that referenced
this pull request
May 27, 2022
…ucture This closes apache#19188.
zstraw
pushed a commit
to zstraw/flink
that referenced
this pull request
Jul 4, 2022
…ucture This closes apache#19188.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.