Skip to content

[FLINK-26849][metrics] Deduplicate metric (un)registration logic #19230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zentol merged 1 commit into from
Mar 28, 2022
Merged

[FLINK-26849][metrics] Deduplicate metric (un)registration logic #19230

zentol merged 1 commit into from
Mar 28, 2022

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Mar 24, 2022

Small refactoring to deduplicate code.

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 24, 2022 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

niklassemmler
niklassemmler approved these changes Mar 28, 2022
View reviewed changes
Copy link

@niklassemmler niklassemmler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zentol zentol merged commit 865299d into apache:master Mar 28, 2022
@zentol zentol deleted the 26849 branch March 28, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@niklassemmler niklassemmler niklassemmler approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component=Runtime/Metrics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zentol @flinkbot @niklassemmler