Skip to content

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented Mar 25, 2022

What is the purpose of the change

To fix the exception thrown when no order keys exists in over() in Hive dialects.

Brief change log

Rewrite over() to over(order by int(1) asc) in the phase of converting Hive AST to Calcite RelNode .

Verifying this change

Additional test query in flink-connectors/flink-connector-hive/src/test/resources/query-test/window.q

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 25, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@luoyuxia luoyuxia changed the title [hive]support over() without order keys inside. [FLINK-27375][hive]support over() without order keys inside. Apr 25, 2022
@luoyuxia luoyuxia force-pushed the support-over-window-without-orderby branch from d907bde to d766621 Compare April 25, 2022 07:16
@luoyuxia luoyuxia changed the title [FLINK-27375][hive]support over() without order keys inside. [FLINK-27375][hive] Fix exception when no order keys exists in over() in Hive Dialect Aug 8, 2022
@luoyuxia luoyuxia closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants