Skip to content

Conversation

@Myracle
Copy link
Contributor

@Myracle Myracle commented Mar 29, 2022

What is the purpose of the change

In setence "- 配置 jobmanager.scheduler: AdpaptiveBatch", the word AdaptiveBatch is spelling wrong which may confuse the users.

Brief change log

  • Modify spelling error in elastic_scaling.md

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Myracle Thanks for the fix, LGTM. Will merge when the CI has passed

@MartijnVisser MartijnVisser self-assigned this Mar 29, 2022
@MartijnVisser MartijnVisser merged commit f5bdb3c into apache:master Mar 29, 2022
@wanglijie95
Copy link
Contributor

wanglijie95 commented Mar 30, 2022

Thanks for your fix @Myracle, and thanks for review @MartijnVisser , can you help to pick this change to release 1.15? Because the release 1.15 also has this problem.

@MartijnVisser
Copy link
Contributor

@wanglijie95 I can definitely cherrypick this fix to release-1.15 but I would like to know if @Myracle doesn't want to do that. I can help in merging it.

@zhuzhurk
Copy link
Contributor

Thanks for reporting and fixing this spelling error! @Myracle
And thanks for reviewing the fix and merging it into master. @MartijnVisser
We absolute need this fix in release-1.15 to avoid misleading users. So I will pick it to release-1.15.

@zhuzhurk
Copy link
Contributor

Merged into release-1.15: 341deb2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants