[hotfix] [connectors/hbase] Fix equal method of HBaseWriteOptions#19300
Closed
LiebingYu wants to merge 1 commit intoapache:masterfrom
Closed
[hotfix] [connectors/hbase] Fix equal method of HBaseWriteOptions#19300LiebingYu wants to merge 1 commit intoapache:masterfrom
LiebingYu wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
Contributor
|
@LB-Yu thanks for your contribution The Flink HBase connector resides in it's own repository nowadays, if this code change is still relevant, please open the PR in https://github.com/apache/flink-connector-hbase/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The
equalsmethod ofHBaseWriteOptionsuses==to determine whether theparallelismof the Integer type is equal, which will cause problems.The relevant code is as follows.
In order to avoid similar problems, I refer to
HBaseLookupOptionsand useObjects.equals()uniformly to judge whether the internal member variables are equal.Brief change log
equalsmethod ofHBaseWriteOptionsVerifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation