-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-27043][table] Removing old csv format references #19349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db38265 to
124ca6e
Compare
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
973166d to
0f28378
Compare
|
@flinkbot run azure |
twalthr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR @slinkydeveloper. I added some comments.
...tests/flink-batch-sql-test/src/main/java/org/apache/flink/sql/tests/BatchSQLTestProgram.java
Outdated
Show resolved
Hide resolved
...le/flink-table-planner/src/test/resources/explain/testExecuteSqlWithExplainDetailsSelect.out
Outdated
Show resolved
Hide resolved
...able/flink-table-planner/src/test/java/org/apache/flink/table/test/WithTableEnvironment.java
Show resolved
Hide resolved
...table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala
Outdated
Show resolved
Hide resolved
...table-planner/src/test/scala/org/apache/flink/table/planner/utils/testTableSourceSinks.scala
Outdated
Show resolved
Hide resolved
c19db77 to
bb3ab8c
Compare
…egacy. Remove LegacyTableSourceITCase, which has tests relying on the old csv connector. Add WithTableEnvironment test annotation to inject table environment. Use JUnit 5/AssertJ and remove usage of old csv factory for TableEnvironmentITCase, TableEnvironmentTest and TableITCase. Removed usage of Csv format from flink-batch-sql-test. Fix remaining tests and remove other legacy tests. Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
bb3ab8c to
13184bc
Compare
|
This PR is being marked as stale since it has not had any activity in the last 180 days. If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed. |
|
This PR has been closed since it has not had any activity in 120 days. |
This PR is preliminary work to get https://issues.apache.org/jira/browse/FLINK-26952 solved (which is blocked currently by an issue of the new csv format).
Changelog: