Skip to content

Conversation

@slinkydeveloper
Copy link
Contributor

This PR is preliminary work to get https://issues.apache.org/jira/browse/FLINK-26952 solved (which is blocked currently by an issue of the new csv format).

Changelog:

  • Remove legacy tests and mocks either using the csv format, or somehow depending on it
  • Added a new test extension to inject the table environment with junit 5
  • Rewrite TableEnvironmentITCase, TableEnvironmentTest and TableITCase with assertj/junit 5
  • Removed usage of old csv format from flink-batch-sql e2e test

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 4, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@slinkydeveloper
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@slinkydeveloper
Copy link
Contributor Author

@flinkbot run azure

@slinkydeveloper slinkydeveloper force-pushed the FLINK-27043 branch 2 times, most recently from 973166d to 0f28378 Compare April 11, 2022 10:28
@slinkydeveloper
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR @slinkydeveloper. I added some comments.

…egacy. Remove LegacyTableSourceITCase, which has tests relying on the old csv connector. Add WithTableEnvironment test annotation to inject table environment. Use JUnit 5/AssertJ and remove usage of old csv factory for TableEnvironmentITCase, TableEnvironmentTest and TableITCase. Removed usage of Csv format from flink-batch-sql-test. Fix remaining tests and remove other legacy tests.

Signed-off-by: slinkydeveloper <francescoguard@gmail.com>
@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 15, 2025
@github-actions
Copy link

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants