-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-27050][runtime] Removes default RpcSystem instance #19353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
I'm investigating the OOM in the integration tests of the |
|
@flinkbot run azure |
|
Force push without additional changes to trigger the CI since the |
a83d4e1 to
629dfa3
Compare
|
Again force-pushed without any additional changes to trigger ci once more... |
|
@flinkbot run azure |
|
Rebased to most-recent |
Having a default RpcSystem in TestingDispatcher.Builder caused threads being spawned without cleanup. Instead, we should rely on the RpcSystem instance provided by the test.
|
Force-pushed once more after the branch idle'd for 5 days to prepare the merge for tomorrow morning... |
|
Error caused by FLINK-26621 which is unrelated to this change. |
What is the purpose of the change
Having a default RpcSystem in TestingDispatcher.Builder
caused threads being spawned without cleanup. Instead, we
should rely on the RpcSystem instance provided by the test.
Brief change log
buildmethodVerifying this change
DispatcherCleanupResourcesTest:Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation