[FLINK-24577][table-planner] Implement Cast from BINARY to RAW #19409
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.functions.casting; | ||
|
|
||
| import org.apache.flink.table.data.binary.BinaryRawValueData; | ||
| import org.apache.flink.table.types.logical.LogicalType; | ||
| import org.apache.flink.table.types.logical.LogicalTypeFamily; | ||
| import org.apache.flink.table.types.logical.LogicalTypeRoot; | ||
|
|
||
| import static org.apache.flink.table.planner.functions.casting.CastRuleUtils.staticCall; | ||
|
|
||
| /** {@link LogicalTypeFamily#BINARY_STRING} to {@link LogicalTypeRoot#RAW} to cast rule. */ | ||
| class BinaryToRawCastRule extends AbstractNullAwareCodeGeneratorCastRule<byte[], Object> { | ||
|
|
||
| static final BinaryToRawCastRule INSTANCE = new BinaryToRawCastRule(); | ||
|
|
||
| private BinaryToRawCastRule() { | ||
| super( | ||
| CastRulePredicate.builder() | ||
| .input(LogicalTypeFamily.BINARY_STRING) | ||
| .target(LogicalTypeRoot.RAW) | ||
| .build()); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean canFail(LogicalType inputLogicalType, LogicalType targetLogicalType) { | ||
| return true; | ||
| } | ||
|
|
||
| /* Example generated code for BINARY(3): | ||
|
|
||
| isNull$0 = _myInputIsNull; | ||
| if (!isNull$0) { | ||
| result$1 = org.apache.flink.table.data.binary.BinaryRawValueData.fromBytes(_myInput); | ||
| isNull$0 = result$1 == null; | ||
| } else { | ||
| result$1 = null; | ||
| } | ||
|
|
||
| */ | ||
|
|
||
| @Override | ||
| protected String generateCodeBlockInternal( | ||
| CodeGeneratorCastRule.Context context, | ||
| String inputTerm, | ||
| String returnVariable, | ||
| LogicalType inputLogicalType, | ||
| LogicalType targetLogicalType) { | ||
| // Get serializer for RAW type | ||
| return new CastRuleUtils.CodeWriter() | ||
| .assignStmt( | ||
| returnVariable, | ||
| staticCall(BinaryRawValueData.class, "fromBytes", inputTerm)) | ||
| .toString(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in this line and in
RexLiteralis a blocker for this PR in my opinion. We should fix these things in Calcite first and only port the changes to the Flink code base, once merged in Calcite.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spent quite some time here, and couldn't find a workaround.
I could modify the PR and only allow it for TableAPI for the moment, and try to fix this in Calcite first.
If it's accepted, have a follow up PR to enable this for SQL in flink.