Skip to content

Conversation

@liuzhuang2017
Copy link
Contributor

@liuzhuang2017 liuzhuang2017 commented Apr 12, 2022

What is the purpose of the change

Fix Chinese page for "Building Flink from Source"

Brief change log

Fix Chinese page for "Building Flink from Source"

Verifying this change

(1) Line 40 in docs/content.zh/docs/flinkDev/building.md is missing an * when compared to the corresponding docs/content/docs/flinkDev/building.md English documentation.
(2) When clicking "Build Flink" under "Build PyFlink #" in the page https://nightlies.apache.org/flink/flink-docs-release-1.14/en/docs/flinkdev/building/#build-flink, and does not jump to "Building Flink #".

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 12, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@liuzhuang2017
Copy link
Contributor Author

@Myasuka ,Can you help me review this pr, thanks.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, please fill up the description of this PR.

@liuzhuang2017
Copy link
Contributor Author

@Myasuka ,Ok,I have updated this pr as you suggested, thanks for your review.

@Myasuka
Copy link
Member

Myasuka commented Apr 13, 2022

@liuzhuang2017 I think you can select "This change is a trivial rework without any test coverage." for the part of Verifying this change. Moreover, you should select the answers for the part of Does this pull request potentially affect one of the following parts.

@MartijnVisser MartijnVisser self-assigned this Apr 14, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants