Skip to content

[FLINK-27221]Improvements to YAML parsing#19449

Closed
Carl-Zhou-CN wants to merge 1 commit intoapache:masterfrom
Carl-Zhou-CN:master
Closed

[FLINK-27221]Improvements to YAML parsing#19449
Carl-Zhou-CN wants to merge 1 commit intoapache:masterfrom
Carl-Zhou-CN:master

Conversation

@Carl-Zhou-CN
Copy link
Copy Markdown
Member

@Carl-Zhou-CN Carl-Zhou-CN commented Apr 13, 2022

What is the purpose of the change

For example, according to the current parsing method, the features of yaml cannot be used, and the password with # in the password cannot be parsed.

Brief change log

(for example:)

  • The TaskInfo is stored in the blob store on job creation time as a persistent artifact
  • Deployments RPC transmits only the blob storage reference
  • TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (100MB)
  • Extended integration test for recovery after master (JobManager) failure
  • Added test that validates that TaskInfo is transferred only once across recoveries
  • Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 13, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Carl-Zhou-CN
Copy link
Copy Markdown
Member Author

@Carl-Zhou-CN Carl-Zhou-CN changed the title Improvements to YAML parsing [FLINK-27221]Improvements to YAML parsing Apr 13, 2022
@zentol
Copy link
Copy Markdown
Contributor

zentol commented Apr 13, 2022

Closing this PR because there is already FLINK-27127, which is quite a bit further along implementation-wise yet still stalled because we are concerned about backwards-compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants