Skip to content

[FLINK-27225][build] Remove redundant reuseForks settings #19462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zentol merged 2 commits into from
Apr 19, 2022
Merged

[FLINK-27225][build] Remove redundant reuseForks settings #19462

zentol merged 2 commits into from
Apr 19, 2022

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Apr 13, 2022

reuseForks is true by default so some settings are redundant. flink-dist contains no unit tests that would justify disabling reuseForks.

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 13, 2022 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@zentol zentol requested a review from XComp April 14, 2022 08:07
XComp
XComp approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zentol zentol merged commit c041b77 into apache:master Apr 19, 2022
@zentol zentol deleted the 27225 branch April 19, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XComp XComp XComp approved these changes

Assignees

No one assigned

Labels

component=BuildSystem component=Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zentol @flinkbot @XComp