Skip to content

Conversation

@fredia
Copy link
Contributor

@fredia fredia commented Apr 18, 2022

What is the purpose of the change

This PR wants to add two fields:

  • changelog_storage
  • changelog_periodic_materialization_interval

into the checkpoints-config response, and show these fields on web UI when changelog is enabled.

Brief change log

  • Add changelog_storage and changelog_periodic_materialization_interval to rest api
  • Add changelog_storage and changelog_periodic_materialization_interval to web ui

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

This change is already covered by existing tests, such as (please describe tests).

  • RestAPIStabilityTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: ( no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Myasuka
Copy link
Member

Myasuka commented May 10, 2022

@fredia would you please share the picture that how the UI looks like with this patch?

@fredia
Copy link
Contributor Author

fredia commented May 10, 2022

Sure. I run SocketWindowWordCount to get WEB UI. Here are pictures:

  • when changelog enable, display changelog_storage and changelog_periodic_materialization_interval in checkpoint configuration tab:
    changgelog enable

  • when changelog disable, don't show changelog_storage and changelog_periodic_materialization_interval:
    image

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR, I think current PR looks in a good shape, please take a look at my comments.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! Please take a look at my comments.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM.

@Myasuka
Copy link
Member

Myasuka commented May 11, 2022

@flinkbot run azure

@Myasuka Myasuka merged commit c47500c into apache:master May 12, 2022
@fredia fredia deleted the changelog_ui branch April 18, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants