-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-27260][Runtime/REST] Expose changelog configurations in Rest API and Web UI #19502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fredia would you please share the picture that how the UI looks like with this patch? |
Myasuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this PR, I think current PR looks in a good shape, please take a look at my comments.
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
Outdated
Show resolved
Hide resolved
Myasuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! Please take a look at my comments.
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
Outdated
Show resolved
Hide resolved
flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html
Outdated
Show resolved
Hide resolved
Myasuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. LGTM.
|
@flinkbot run azure |


What is the purpose of the change
This PR wants to add two fields:
into the checkpoints-config response, and show these fields on web UI when changelog is enabled.
Brief change log
changelog_storageandchangelog_periodic_materialization_intervalto rest apichangelog_storageandchangelog_periodic_materialization_intervalto web uiVerifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change is already covered by existing tests, such as (please describe tests).
RestAPIStabilityTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation