[FLINK-25550][k8s] Migrate flink-k8s module's test from junit4 to junit5#19560
Merged
zentol merged 3 commits intoapache:masterfrom Apr 27, 2022
reswqa:junit5_k8s
Merged
[FLINK-25550][k8s] Migrate flink-k8s module's test from junit4 to junit5#19560zentol merged 3 commits intoapache:masterfrom reswqa:junit5_k8s
zentol merged 3 commits intoapache:masterfrom
reswqa:junit5_k8s
Conversation
…ate tests from junit assert to AssertJ
Collaborator
Member
Author
|
@flinkbot run azure |
Migrate flink-k8s test from junit4 to junit5
Member
Author
|
@flinkbot run azure |
zentol
requested changes
Apr 25, 2022
Contributor
zentol
left a comment
There was a problem hiding this comment.
I'm unable to checkout the branch. please double-check whether there isn't a trailing space in the file name:
error: invalid path 'flink-kubernetes/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension '
CI is also failing
...kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesClusterClientFactoryTest.java
Outdated
Show resolved
Hide resolved
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesExtension.java
Outdated
Show resolved
Hide resolved
...ubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriverTest.java
Outdated
Show resolved
Hide resolved
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesTestBase.java
Outdated
Show resolved
Hide resolved
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesTestBase.java
Show resolved
Hide resolved
...-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/FlinkPodTest.java
Outdated
Show resolved
Hide resolved
...-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/FlinkPodTest.java
Outdated
Show resolved
Hide resolved
...-kubernetes/src/test/java/org/apache/flink/kubernetes/kubeclient/resources/FlinkPodTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesLeaderElectorITCase.java
Show resolved
Hide resolved
...rc/test/java/org/apache/flink/kubernetes/kubeclient/resources/KubernetesPodsWatcherTest.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@zentol Thank you very much for your timely and patient reviews and suggestions. I replied to your comments for some places that I am not sure how to modify. I will submit all the modifications after I determine how to modify them here. |
Member
Author
|
@zentol I submitted a new commit to meet the review comment. Please have a look when you have time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Migrate flink-k8s module's test from junit4 to junit5.
Brief change log
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation