Skip to content

[FLINK-25550][k8s] Migrate flink-k8s module's test from junit4 to junit5#19560

Merged
zentol merged 3 commits intoapache:masterfrom
reswqa:junit5_k8s
Apr 27, 2022
Merged

[FLINK-25550][k8s] Migrate flink-k8s module's test from junit4 to junit5#19560
zentol merged 3 commits intoapache:masterfrom
reswqa:junit5_k8s

Conversation

@reswqa
Copy link
Copy Markdown
Member

@reswqa reswqa commented Apr 24, 2022

What is the purpose of the change

Migrate flink-k8s module's test from junit4 to junit5.

Brief change log

  • migrate tests from junit assert to AssertJ
  • migrate tests from junit4 to junit5

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies : no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Apr 24, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 24, 2022

@flinkbot run azure

2 similar comments
@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 24, 2022

@flinkbot run azure

@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 25, 2022

@flinkbot run azure

Migrate flink-k8s test from junit4 to junit5
@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 25, 2022

@flinkbot run azure

@zentol zentol self-assigned this Apr 25, 2022
Copy link
Copy Markdown
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to checkout the branch. please double-check whether there isn't a trailing space in the file name:

error: invalid path 'flink-kubernetes/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension '

CI is also failing

@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 26, 2022

@zentol Thank you very much for your timely and patient reviews and suggestions. I replied to your comments for some places that I am not sure how to modify. I will submit all the modifications after I determine how to modify them here.

@reswqa
Copy link
Copy Markdown
Member Author

reswqa commented Apr 26, 2022

@zentol I submitted a new commit to meet the review comment. Please have a look when you have time.

@zentol zentol merged commit 6fc5f78 into apache:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants