[FLINK-26414][hive] Hive dialect supports macro #19561
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,9 @@ | |
| package org.apache.flink.table.functions.hive; | ||
|
|
||
| import org.apache.flink.annotation.Internal; | ||
| import org.apache.flink.util.Preconditions; | ||
|
|
||
| import org.apache.hadoop.hive.ql.exec.SerializationUtilities; | ||
| import org.apache.hadoop.hive.ql.exec.UDF; | ||
|
|
||
| import java.io.Serializable; | ||
|
|
@@ -36,23 +38,53 @@ public class HiveFunctionWrapper<UDFType> implements Serializable { | |
| public static final long serialVersionUID = 393313529306818205L; | ||
|
|
||
| private final String className; | ||
| // a field to hold the string serialized for the UDF. | ||
| // we sometimes need to hold it in case of some serializable UDF will contain | ||
| // additional information such as Hive's GenericUDFMacro and if we construct the UDF directly by | ||
| // getUDFClass#newInstance, the information will be missed. | ||
| private String udfSerializedString; | ||
|
|
||
| private transient UDFType instance = null; | ||
|
|
||
| public HiveFunctionWrapper(String className) { | ||
| this.className = className; | ||
| } | ||
|
|
||
| /** | ||
| * Create a HiveFunctionWrapper with a UDF instance. In this constructor, the instance will be | ||
| * serialized to string and held on in the HiveFunctionWrapper. | ||
| */ | ||
| public HiveFunctionWrapper(String className, UDFType serializableInstance) { | ||
| this(className); | ||
| Preconditions.checkArgument( | ||
| serializableInstance.getClass().getName().equals(className), | ||
| String.format( | ||
| "Expect the UDF is instance of %s, but is instance of %s.", | ||
| className, serializableInstance.getClass().getName())); | ||
| Preconditions.checkArgument( | ||
| serializableInstance instanceof Serializable, | ||
| String.format( | ||
| "The UDF %s should be an instance of Serializable.", | ||
| serializableInstance.getClass().getName())); | ||
| // we need to use the SerializationUtilities#serializeObject to serialize UDF for the UDF | ||
| // may not be serialized by Java serializer | ||
| this.udfSerializedString = | ||
| SerializationUtilities.serializeObject((Serializable) serializableInstance); | ||
| } | ||
|
|
||
| /** | ||
| * Instantiate a Hive function instance. | ||
| * | ||
| * @return a Hive function instance | ||
| */ | ||
| public UDFType createFunction() { | ||
| if (udfSerializedString != null) { | ||
| // deserialize the string to udf instance | ||
| return deserializeUDF(); | ||
| } else if (instance != null) { | ||
| return instance; | ||
| } else { | ||
| UDFType func; | ||
| try { | ||
| func = getUDFClass().newInstance(); | ||
| } catch (InstantiationException | IllegalAccessException | ClassNotFoundException e) { | ||
|
|
@@ -88,4 +120,20 @@ public String getClassName() { | |
| public Class<UDFType> getUDFClass() throws ClassNotFoundException { | ||
| return (Class<UDFType>) Thread.currentThread().getContextClassLoader().loadClass(className); | ||
| } | ||
|
|
||
| /** | ||
| * Deserialize UDF used the udfSerializedString held on. | ||
| * | ||
| * @return the UDF deserialized | ||
| */ | ||
| private UDFType deserializeUDF() { | ||
| try { | ||
| return (UDFType) | ||
| SerializationUtilities.deserializeObject( | ||
| udfSerializedString, (Class<Serializable>) getUDFClass()); | ||
|
Member
There was a problem hiding this comment. This is problematic in the case the hive connector is dynamically loaded, i.e. in the user classloader instead of the current class loader. We should use the user classloader to load classes. Could you create a JIRA issue for this?
Contributor
Author
There was a problem hiding this comment. Of course, I have created FLINK-28430 for it. |
||
| } catch (ClassNotFoundException e) { | ||
| throw new FlinkHiveUDFException( | ||
| String.format("Failed to deserialize function %s.", className), e); | ||
| } | ||
|
Contributor
There was a problem hiding this comment. "Failed to deserialize function %s." |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check the class name is equal to the class of
serializableInstance.