Skip to content

[hotfix] Ignore Hugo Module files#19642

Merged
MartijnVisser merged 1 commit intoapache:release-1.15from
MartijnVisser:BP/gitignore-hugo/1.15
May 5, 2022
Merged

[hotfix] Ignore Hugo Module files#19642
MartijnVisser merged 1 commit intoapache:release-1.15from
MartijnVisser:BP/gitignore-hugo/1.15

Conversation

@MartijnVisser
Copy link
Copy Markdown
Contributor

What is the purpose of the change

  • Make sure that Hugo Modules files (which can be created while working on the current master branch) will be ignored when working with the currently support release-1.15 and release-1.14 branches

Brief change log

  • Updated .gitignore

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 4, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@MartijnVisser MartijnVisser requested a review from zentol May 4, 2022 20:43
Copy link
Copy Markdown
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove leading slash (because it's a bit weird even if it works...)

@zentol zentol self-assigned this May 5, 2022
@MartijnVisser
Copy link
Copy Markdown
Contributor Author

maybe remove leading slash (because it's a bit weird even if it works...)

We also have those in for other ignores in the docs folder:

/docs/api
/docs/.bundle
/docs/.rubydeps
/docs/ruby2/.bundle
/docs/ruby2/.rubydeps
/docs/.jekyll-metadata

@zentol
Copy link
Copy Markdown
Contributor

zentol commented May 5, 2022

I saw that; it's still weird :P

@MartijnVisser MartijnVisser force-pushed the BP/gitignore-hugo/1.15 branch from 1497c41 to 83dca21 Compare May 5, 2022 07:37
@MartijnVisser
Copy link
Copy Markdown
Contributor Author

I saw that; it's still weird :P

OK, fixed them all in one go

@MartijnVisser MartijnVisser merged commit cf55b0d into apache:release-1.15 May 5, 2022
@MartijnVisser MartijnVisser deleted the BP/gitignore-hugo/1.15 branch May 5, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants