Skip to content

Conversation

@luoyuxia
Copy link
Contributor

@luoyuxia luoyuxia commented May 5, 2022

What is the purpose of the change

To support multi-insert statement for Hive dialect.

Brief change log

  • Construct ModifyOperation separately for each insert fragment in one single multi-insert statement.
  • Compose these ModifyOperations to StatementSetOperation.

Verifying this change

The addition test in ...connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectQueryITCase.java#testMultiInsert

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? N/A

@flinkbot
Copy link
Collaborator

flinkbot commented May 5, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@luoyuxia
Copy link
Contributor Author

luoyuxia commented Jul 5, 2022

@flinkbot run azure

1 similar comment
@luoyuxia
Copy link
Contributor Author

luoyuxia commented Jul 6, 2022

@flinkbot run azure

@luoyuxia luoyuxia force-pushed the FLINK-27387 branch 2 times, most recently from 266b661 to 972df7a Compare July 8, 2022 04:56
@wuchong
Copy link
Member

wuchong commented Jul 29, 2022

Looks good to me in general. Btw, does it also support EXPLAIN? Could you add a test for it?

@luoyuxia
Copy link
Contributor Author

Looks good to me in general. Btw, does it also support EXPLAIN? Could you add a test for it?

Now, I add a test for explain in testMultiInsert

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuchong wuchong merged commit bed7993 into apache:master Jul 30, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants