Skip to content

Conversation

@Myasuka
Copy link
Member

@Myasuka Myasuka commented May 11, 2022

What is the purpose of the change

Introduce and expose RocksDB statistics as metrics.

Brief change log

  • Introduce RocksDB statistics based metrics.
  • Expose these native metrics via RocksDBNativeMetricMonitor.

Verifying this change

This change added tests and can be verified as follows: RocksDBNativeMetricMonitorTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? docs

@flinkbot
Copy link
Collaborator

flinkbot commented May 11, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@masteryhx masteryhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I've left some comments, PTAL.

// RocksDB statistics based metrics, report at database level
// --------------------------------------------------------------------------------------------

public static final ConfigOption<Boolean> MONITOR_BLOCK_CACHE_HIT =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also create a new class called "RocksDBStatistics" and use it just like "RocksDBProperty" ?
Maybe it could be clearer to me. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I think previous RocksDBProperty is a bit complex, and I prefer to use the full metrics name in the source code as it could be easily searched.

@masteryhx
Copy link
Contributor

LGTM

@Myasuka
Copy link
Member Author

Myasuka commented Jul 12, 2022

@flinkbot run azure

1 similar comment
@Myasuka
Copy link
Member Author

Myasuka commented Jul 12, 2022

@flinkbot run azure

@Myasuka
Copy link
Member Author

Myasuka commented Jul 14, 2022

@masteryhx Thanks for the review, and I will merge this PR since the CI is green finally.

@Myasuka Myasuka merged commit 46e0014 into apache:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants