Skip to content

Conversation

@zhuzhurk
Copy link
Contributor

What is the purpose of the change

A meaningful ExecutionAttemptID can help in many places, including improve log readability and add an easy way to find the corresponding execution vertex.

Brief change log

  • Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber(int type)
  • Refactor the usages of ExecutionAttemptID to ensure param consistency

Verifying this change

This change is already covered by existing tests.
Manual e2e tests are run against this change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented May 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also left a comment in JIRA, PTAL.

@zhuzhurk zhuzhurk force-pushed the FLINK-17295-refactor-execution-id branch from f526ff4 to 1692d21 Compare May 18, 2022 08:15
@zhuzhurk zhuzhurk force-pushed the FLINK-17295-refactor-execution-id branch from de80e76 to 2aee7d6 Compare May 20, 2022 04:22
@zhuzhurk zhuzhurk force-pushed the FLINK-17295-refactor-execution-id branch from 2aee7d6 to 0b0e95f Compare May 20, 2022 04:26
@zhuzhurk
Copy link
Contributor Author

Thanks for reviewing! @zentol @KarmaGYZ
Merging.

@zhuzhurk zhuzhurk merged commit 014e8e0 into apache:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants