-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber #19747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhuzhurk
merged 8 commits into
apache:master
from
zhuzhurk:FLINK-17295-refactor-execution-id
May 20, 2022
Merged
[FLINK-17295][runtime] Refactor the ExecutionAttemptID to consist of ExecutionGraphID, ExecutionVertexID and attemptNumber #19747
zhuzhurk
merged 8 commits into
apache:master
from
zhuzhurk:FLINK-17295-refactor-execution-id
May 20, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zentol
requested changes
May 17, 2022
Contributor
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also left a comment in JIRA, PTAL.
...k-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionID.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
Outdated
Show resolved
Hide resolved
...k-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
Show resolved
Hide resolved
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java
Outdated
Show resolved
Hide resolved
KarmaGYZ
requested changes
May 18, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraphID.java
Outdated
Show resolved
Hide resolved
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ExecutionVertexID.java
Show resolved
Hide resolved
f526ff4 to
1692d21
Compare
zentol
reviewed
May 19, 2022
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraph.java
Outdated
Show resolved
Hide resolved
de80e76 to
2aee7d6
Compare
…utionGraphId, executionVertexId and attemptNumber
…ertexId, subtaskIndex, attemptNumber and executionAttemptId
2aee7d6 to
0b0e95f
Compare
zentol
approved these changes
May 20, 2022
KarmaGYZ
approved these changes
May 20, 2022
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
A meaningful ExecutionAttemptID can help in many places, including improve log readability and add an easy way to find the corresponding execution vertex.
Brief change log
Verifying this change
This change is already covered by existing tests.
Manual e2e tests are run against this change.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation