[FLINK-3852] update the quickstart module to include a streaming skeleton#1982
[FLINK-3852] update the quickstart module to include a streaming skeleton#1982mred-cmd wants to merge 2 commits intoapache:masterfrom
Conversation
mred-cmd
commented
May 11, 2016
mred-cmd
commented
- Added skeleton StreamingJob
- Moved Job to BatchJob
- Commented out transformers for the mainClass setting with a guide to uncomment
- Updated java and scala docs with a guide on how to run via the cli
- Updated the site docs to include all four sample classes
- Tidied up SocketTextStreamWordCount
…ented out transformers for the mainClass setting, tidied up SocketTextStreamWordCount and updated docs
| * You will find the jar in | ||
| * target/flink-quickstart-0.1-SNAPSHOT-Sample.jar | ||
| * | ||
| * target/flink-quickstart-0.1-SNAPSHOT.jar |
There was a problem hiding this comment.
Should we update the version in this line too?
There was a problem hiding this comment.
Sorry, I misunderstood. The naming of the jar here depends on the user.
|
Made comments on some rather trivial javadoc / comment related stuff, overall the PR looks good! I'm not a committer, so I would suggest to wait for a committer/maintainer to take a look at the changes too before you proceed with any more modifications. |
mred-cmd
force-pushed
the
FLINK-3852-quickstart-streaming
branch
5 times, most recently
from
3b7e644 to
6cb9a09
Compare
… fixed DataSet to DataStream for streaming jobs and fixed indentation
|
Thanks for the review @tzulitai I've pushed fixes for all your comments 👍 |
|
I like the pull request! (You updated the docs, the PR describes the changes). +1 to merge |
|
Merging this... |
|
Thanks for reworking the quickstart jobs @MarkReddy. Change look good to me. |
|
Race condition ;-) |
|
No, names are OK. |
- move Job to BatchJob - comment out transformers for the mainClass setting - tidy up SocketTextStreamWordCount - update docs This closes apache#1982
5 participants
