Skip to content

Conversation

@snuyanzin
Copy link
Contributor

What is the purpose of the change

  1. Migrate flink-connectors-rabbitmq module to AssertJ and JUnit 5 following the JUnit 5 Migration Guide
  2. Fix RestClusterClient injection

Brief change log

Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest

Verifying this change

This change is a code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no )
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 8, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for creating the PR, @snuyanzin . I have a few minor cosmetic comments.

Copy link
Contributor

@XComp XComp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Please squash the commits and rebase the branch.

@snuyanzin
Copy link
Contributor Author

@flinkbot run azure

@snuyanzin
Copy link
Contributor Author

Thanks for the feedback

Please squash the commits and rebase the branch.

done

@snuyanzin snuyanzin requested a review from XComp October 5, 2022 08:59
@XComp XComp merged commit d191bda into apache:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants