-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-27942][tests] Migrate flink-connectors-rabbitmq to JUnit5 #19914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...parent/flink-test-utils/src/main/java/org/apache/flink/test/junit5/MiniClusterExtension.java
Outdated
Show resolved
Hide resolved
|
@flinkbot run azure |
XComp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for creating the PR, @snuyanzin . I have a few minor cosmetic comments.
...r-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceITCase.java
Outdated
Show resolved
Hide resolved
...tor-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfigTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfigTest.java
Outdated
Show resolved
Hide resolved
...r-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceITCase.java
Outdated
Show resolved
Hide resolved
33a8f58 to
75f415b
Compare
XComp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Please squash the commits and rebase the branch.
|
@flinkbot run azure |
|
Thanks for the feedback
done |
What is the purpose of the change
Brief change log
Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
Verifying this change
This change is a code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation