-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[WIP][FLINK-27966][python] All the classes move to the connector specific files #19919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'FileEnumeratorProvider', | ||
| 'FileSink', | ||
| 'FileSource', | ||
| 'BucketAssigner', | ||
| 'FileSourceBuilder', | ||
| 'FileSplitAssignerProvider', | ||
| 'FlinkKafkaConsumer', | ||
| 'FlinkKafkaProducer', | ||
| 'Semantic', | ||
| 'JdbcSink', | ||
| 'JdbcConnectionOptions', | ||
| 'JdbcExecutionOptions', | ||
| 'NumberSequenceSource', | ||
| 'OutputFileConfig', | ||
| 'PulsarDeserializationSchema', | ||
| 'PulsarSource', | ||
| 'PulsarSourceBuilder', | ||
| 'SubscriptionType', | ||
| 'PulsarSerializationSchema', | ||
| 'PulsarSink', | ||
| 'PulsarSinkBuilder', | ||
| 'MessageDelayer', | ||
| 'TopicRoutingMode', | ||
| 'RMQConnectionConfig', | ||
| 'RMQSource', | ||
| 'RMQSink', | ||
| 'RollingPolicy', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dianfu Should we also move the file connector classes? If so, I will also change its corresponding docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deadwind4 Yes, of course. BTW, we should also considering the backward compatibility. One way that may work is adding the following code in the connector/init.py:
def _install():
from pyflink.datastream.connectors import jdbc
setattr(pyflink.datastream.connectors, 'JdbcSink', jdbc.JdbcSink)
...
_install()
del _install
|
Closed which has been addressed in 9dd2b19995beb766f0cd0986b079f2d210c1e836 |
What is the purpose of the change
If all the classes are placed
connectors/_init_.py, conflicts may happen that two classes belonging to two different connectors having the same name.Brief change log
connectors/_init_.pyVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation