Skip to content

Conversation

@StephanEwen
Copy link
Contributor

This PR adds an AbstractDeserializationSchema that handles the produced type extraction automatically from the generic types via the TypeExtractor (reflection)

Also adds test and documentation, references the new AbstractDeserializationSchema in the docs of the DeserializationSchema.

…andles produced type extraction.

The AbstractDeserializationSchema creates the produced type information automatically from the
generic parameters.
If you experience any issues with the Kafka consumer on the client side, the client log might contain information about failed requests, etc.

##### The `DeserializationSchema`
##### **The `DeserializationSchema`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the **? The other section headings don't have it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole doc uses pretty low weight formatting. It is hard to recognize a heading as such. I overlooked the section initially.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kafka.md uses very low level headings. The batch and streaming guides use level 2 headings for top-level headings while kafka.md uses level 4. I think the solution is to reduce heading level by 2 on all levels in this document, which would yield

### The `DeserializationSchema`

@aljoscha
Copy link
Contributor

LGTM except for a minor comment in the doc

@aljoscha
Copy link
Contributor

Good addition that simplifies user's lives, I just saw someone on stack overflow who was struggling with how to get the TypeInformation for getOutputType.

@asfgit asfgit closed this in 92e1c82 May 20, 2016
mbode pushed a commit to mbode/flink that referenced this pull request May 27, 2016
…andles produced type extraction.

The AbstractDeserializationSchema creates the produced type information automatically from the
generic parameters.

This closes apache#2010
@StephanEwen StephanEwen deleted the abstract_schema branch August 1, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants