[FLINK-27587][python] Support keyed co-broadcast processing #20144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
HuangXingBo
reviewed
Jul 14, 2022
| __all__ = ['CloseableIterator', 'DataStream', 'KeyedStream', 'ConnectedStreams', 'WindowedStream', | ||
| 'DataStreamSink', 'CloseableIterator', 'BroadcastStream', 'BroadcastConnectedStream'] | ||
|
|
||
| from pyflink.util.java_utils import to_jarray |
Contributor
There was a problem hiding this comment.
move the import before __all__
| :param ds: The DataStream with which this stream will be connected. | ||
| :return: The ConnectedStreams. | ||
| .. versionchanged:: 1.16.0 | ||
| Support connect BroadcastStream |
Contributor
There was a problem hiding this comment.
Suggested change
| Support connect BroadcastStream | |
| Support connect BroadcastStream |
Comment on lines
+1397
to
+1398
| :param ctx: A :class:`BroadcastProcessFunction.ReadOnlyContext` that allows querying the | ||
| timestamp of the element, querying the current processing/event time and reading the |
Contributor
There was a problem hiding this comment.
Suggested change
| :param ctx: A :class:`BroadcastProcessFunction.ReadOnlyContext` that allows querying the | |
| timestamp of the element, querying the current processing/event time and reading the | |
| :param ctx: | |
| A :class:`BroadcastProcessFunction.ReadOnlyContext` that allows querying the | |
| timestamp of the element, querying the current processing/event time and reading the |
| * org.apache.flink.streaming.runtime.translators.python.PythonKeyedBroadcastStateTransformationTranslator}. | ||
| */ | ||
| @Internal | ||
| public class PythonKeyedBroadcastStateTransformation<OUT> |
Contributor
There was a problem hiding this comment.
Could PythonKeyedBroadcastStateTransformation extend PythonBroadcastStateTransformation
Contributor
Author
There was a problem hiding this comment.
I've tried before, but there's just some class casting cannot be solved.
| * @param <OUT> The output type of the CoBroadcastProcess function | ||
| */ | ||
| @Internal | ||
| public class PythonBatchKeyedCoBroadcastProcessOperator<OUT> |
| public class PythonBatchKeyedCoBroadcastProcessOperator<OUT> | ||
| extends PythonKeyedCoProcessOperator<OUT> implements BoundedMultiInput, InputSelectable { | ||
|
|
||
| private transient volatile boolean isBroadcastSideDone; |
Contributor
There was a problem hiding this comment.
Suggested change
| private transient volatile boolean isBroadcastSideDone; | |
| private transient volatile boolean isBroadcastSideDone = false; |
Vancior
force-pushed
the
feat/py_keyed_broadcast
branch
from
f292e4b to
7edad7b
Compare
HuangXingBo
approved these changes
Jul 15, 2022
JunRuiLee
pushed a commit
to JunRuiLee/flink
that referenced
this pull request
Jul 20, 2022
liujiawinds
pushed a commit
to liujiawinds/flink
that referenced
this pull request
Jul 22, 2022
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR implements keyed broadcast processing (
KeyedStream.connect(BroadcastStream).process(KeyedBroadcastProcessFunction)) in PyFlink.Brief change log
KeyedBroadcastProcessFunctioninterface in PythonKeyedBroadcastStateTransformationand its translator in compile keyed broadcast processing intoPythonKeyedCoProcessororPythonBatchKeyedCoBroadcastProcessOperator.Verifying this change
This change added tests and can be verified as follows:
test_keyed_co_broadcast_processin test_data_stream.pyDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes)Documentation