[FLINK-28549][python] Support DataStream PythonProcessOperator in Thread Mode #20276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dianfu
reviewed
Jul 25, 2022
| actual.sort() | ||
| self.assertEqual(expected, actual) | ||
|
|
||
| def test_basic_operations(self): |
Contributor
There was a problem hiding this comment.
Could we refactor the test cases a bit and move test cases to be executed in both process mode and thread mode in one class?
| return ((SimpleOperatorFactory<?>) streamOperatorFactory).getOperator() | ||
| instanceof AbstractDataStreamPythonFunctionOperator; | ||
| instanceof AbstractExternalDataStreamPythonFunctionOperator | ||
| || ((SimpleOperatorFactory<?>) streamOperatorFactory).getOperator() |
Contributor
There was a problem hiding this comment.
instance of DataStreamPythonFunctionOperator
| if (PythonConfigUtil.isPythonDataStreamOperator(upTransform)) { | ||
| final AbstractDataStreamPythonFunctionOperator<?> upOperator = | ||
| (AbstractDataStreamPythonFunctionOperator<?>) | ||
| final AbstractExternalDataStreamPythonFunctionOperator<?> upOperator = |
Contributor
There was a problem hiding this comment.
DataStreamPythonFunctionOperator?
dianfu
approved these changes
Jul 26, 2022
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…ead Mode This closes apache#20276.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request will support DataStream PythonProcessOperator in Thread Mode
Brief change log
EmbeddedPythonProcessOperatorVerifying this change
This change added tests and can be verified as follows:
EmbeddedDataStreamTestsintest_data_stream.pyDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation