Flink 23528 fix master #20344
Merged
Flink 23528 fix master #20344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 22, 2022 09:54
…#close. DataStream#executeAndCollect expects the CollectSinkOperator to register the accumulator at the end of the application or fails with some exception. However, a stop-with-savepoint without drain would not trigger CollectSinkOperator#finish and thus skip the registration.
…in KinesisDataFetcherTest. Mockito makes it so much harder to debug tests. Here, we replace Mockito with a small test class that emulates the previously dispersed functionality in a simpler way.
…to avoid InterruptionExceptions.
…rite stopWithSavepoint.
dzikosc
force-pushed
the
FLINK-23528-fix-master
branch
from
0f581d9 to
6de038b
Compare
Collaborator
dzikosc
force-pushed
the
FLINK-23528-fix-master
branch
from
6de038b to
0cc29ff
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Make necessary changes for KDS connector to survive stop-with-savepoint workflow. Based on:
#17189
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
yes/ no)@Public(Evolving): (yes/ no)yes/ no /don't know)yes/ no /don't know)yes/ no /don't know)yes/ no /don't know)Documentation
yes/ no)docs / JavaDocs / not documented)