Skip to content

Conversation

@rkhachatryan
Copy link
Contributor

What is the purpose of the change

Please see ticket description (FLINK-28647).

Brief changelog

  • update the docs (checkpoint folder is deleted but with a delay)
  • remove additional error handling (just fail in case of folder deletion failure)

Verifying this change

This change is a trivial rework without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 22, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@fredia
Copy link
Contributor

fredia commented Jul 22, 2022

Thanks for the PR, LGTM(non-binding).

@rkhachatryan rkhachatryan requested a review from dawidwys July 22, 2022 13:16
@rkhachatryan
Copy link
Contributor Author

Thanks for the review @fredia
@dawidwys would you like to take a look as well?

@rkhachatryan rkhachatryan merged commit 17a782c into apache:master Aug 5, 2022
@rkhachatryan rkhachatryan deleted the f28647 branch August 5, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants