Skip to content

[FLINK-28713][tests] Remove unused curator-test dependency#20381

Merged
zentol merged 1 commit into
apache:masterfrom
zentol:remove_curator_test
Aug 5, 2022
Merged

[FLINK-28713][tests] Remove unused curator-test dependency#20381
zentol merged 1 commit into
apache:masterfrom
zentol:remove_curator_test

Conversation

@zentol
Copy link
Copy Markdown
Contributor

@zentol zentol commented Jul 27, 2022

Removes an unused dependency.

end-to-end-tests-common-elasticsearch now has a direct compile dependency on junit-jupiter, which previously got pulled in by curator-test.
sql-client no longer excludes guava from hadoop-common, because guava was previously pulled in by curator-test and is still required by the annoying KerberosDelegationTokenManager which automatically activates when hadoop-common is on the classpath.

Core benefit is one less dependency being pulled into user projects (which also pulls in log4j1).

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Jul 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@alpinegizmo alpinegizmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for caring about this!

@zentol zentol merged commit 6335b57 into apache:master Aug 5, 2022
@zentol zentol deleted the remove_curator_test branch September 1, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants