[FLINK-28713][tests] Remove unused curator-test dependency#20381
Merged
Conversation
Collaborator
alpinegizmo
approved these changes
Aug 5, 2022
Contributor
alpinegizmo
left a comment
There was a problem hiding this comment.
Thanks for caring about this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes an unused dependency.
end-to-end-tests-common-elasticsearchnow has a direct compile dependency onjunit-jupiter, which previously got pulled in bycurator-test.sql-clientno longer excludesguavafromhadoop-common, becauseguavawas previously pulled in bycurator-testand is still required by the annoyingKerberosDelegationTokenManagerwhich automatically activates whenhadoop-commonis on the classpath.Core benefit is one less dependency being pulled into user projects (which also pulls in log4j1).