-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-28459][table-planner] Supports non-atomic CREATE TABLE AS SELECT #20392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@flinkbot run azure |
lsyldliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tartarus0zm Thanks for your contribution, I left some comments.
...anner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableSinkITCase.scala
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableSinkITCase.scala
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/TableSinkITCase.scala
Show resolved
Hide resolved
...anner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala
Show resolved
Hide resolved
...planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java
Outdated
Show resolved
Hide resolved
...planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java
Outdated
Show resolved
Hide resolved
...planner/src/main/java/org/apache/flink/table/planner/operations/SqlCreateTableConverter.java
Outdated
Show resolved
Hide resolved
lsyldliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also explain why not can add ctas plan related test in comment.
...anner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TableSinkITCase.scala
Show resolved
Hide resolved
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What is the purpose of the change
Brief change log
Modify the SqlCreateTableConverter and SqlToOperationConverter to support non-atomic CREATE TABLE AS SELECT
Verifying this change
add ITCase
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation