Skip to content

Conversation

@maosuhan
Copy link
Contributor

@maosuhan maosuhan commented Aug 1, 2022

After this feature has been done https://issues.apache.org/jira/browse/FLINK-18202, we should write a doc to introduce how to use the protobuf format in SQL.

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 1, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maosuhan Thanks a lot for the docs! Some minor fixes, we do need to add Protobuf to the sql_connectors_yml file to make sure it's downloadable/embedded properly.

maosuhan and others added 9 commits August 2, 2022 10:51
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Co-authored-by: MartijnVisser <martijn@2symbols.com>
Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maosuhan Thanks for the PR! I've added the needed data for displaying the Maven dependency and I've also copied the doc to the Chinese content directory. Anything to add from your end? Else I'll merge it.

@libenchao
Copy link
Member

Thanks @maosuhan for contributing this, and @MartijnVisser for reviewing.
Do you think it's necessary to add some notes about the compiled pb classes. This is different from avro format because we need users to provide the compiled protobuf classes.

@MartijnVisser
Copy link
Contributor

@libenchao I'm assuming we're talking about the .desc files a user should have?

@maosuhan
Copy link
Contributor Author

maosuhan commented Aug 2, 2022

@MartijnVisser @libenchao Thanks for your reviewing and I have updated the doc also I wrote more detailed information about how to use it. Anything I should change from your side?

@libenchao
Copy link
Member

libenchao commented Aug 3, 2022

I'm assuming we're talking about the .desc files a user should have?

@MartijnVisser I mean the java classes compiled from the .desc file by protoc, we need users to do this step and provide the classes when submitting the flink job.

maosuhan and others added 2 commits August 3, 2022 09:51
Co-authored-by: Benchao Li <libenchao@gmail.com>
Co-authored-by: Benchao Li <libenchao@gmail.com>
@maosuhan
Copy link
Contributor Author

maosuhan commented Aug 3, 2022

@libenchao thanks for the suggestion. Changes have been committed.

Copy link
Member

@libenchao libenchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@libenchao libenchao closed this in 92ec61a Aug 3, 2022
snuyanzin pushed a commit to snuyanzin/flink that referenced this pull request Aug 4, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants