[FLINK-28893][table] Add built-in conv function. #20544
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
liuyongvs
force-pushed
the
add_conv_function
branch
3 times, most recently
from
eba4c9d to
5cf2143
Compare
Contributor
Author
liuyongvs
force-pushed
the
add_conv_function
branch
2 times, most recently
from
df95134 to
f81848c
Compare
liuyongvs
force-pushed
the
add_conv_function
branch
from
f81848c to
8279928
Compare
snuyanzin
reviewed
Aug 18, 2022
| return null; | ||
| } | ||
| byte[] bytes = | ||
| BaseConversionUtils.conv( |
Contributor
There was a problem hiding this comment.
Could you please clarify why BaseConversionUtils is required and e.g. java.lang.Long#toString(long, int) is not sutable here?
snuyanzin
reviewed
Aug 18, 2022
| null, | ||
| STRING().nullable())) | ||
|
|
||
| // fromBase cannot be negative. |
Contributor
There was a problem hiding this comment.
it is also mentioned that min base is 2 and max is 36
it would be great to see tests for such cases when base is 1 or 37 e.g.
Contributor
|
Thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add built-in conv function.