Skip to content

[FLINK-28950][HBase] Disable HBase2 version check in hbase-default.xml#20562

Closed
xicm wants to merge 2 commits intoapache:masterfrom
xicm:FLINK-28950
Closed

[FLINK-28950][HBase] Disable HBase2 version check in hbase-default.xml#20562
xicm wants to merge 2 commits intoapache:masterfrom
xicm:FLINK-28950

Conversation

@xicm
Copy link
Copy Markdown

@xicm xicm commented Aug 12, 2022

What is the purpose of the change

With the version check enabled, hbase connector can write to hbase 2.2.3 only. Disable the version check to support hbase 2.X.

Brief change log

Update the default value of hbase.defaults.for.version.skip in
flink-connectors/flink-sql-connector-hbase-2.2/src/main/resources/hbase-default.xml

Verifying this change

Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing

(Please pick either of the following options)

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented Aug 12, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@xicm xicm changed the title [FLINK-28950] Disable HBase2 version check in hbase-default.xml [FLINK-28950][HBase] Disable HBase2 version check in hbase-default.xml Aug 12, 2022
@xicm
Copy link
Copy Markdown
Author

xicm commented Aug 13, 2022

@flinkbot run azure

@snuyanzin
Copy link
Copy Markdown
Contributor

snuyanzin commented Oct 19, 2023

@xicm thanks for your contribution
The Flink HBase connector resides in it's own repository nowadays, if this code change is still relevant, please open the PR in https://github.com/apache/flink-connector-hbase/

@snuyanzin snuyanzin closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants