-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-28992][table-planner] fix: Change Ndv takes the max value instead of sum of all partitions when getting partition table column stats #20595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
@flinkbot run azure |
godfreyhe
reviewed
Aug 18, 2022
Contributor
godfreyhe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I left a few comments
...table/flink-table-common/src/test/java/org/apache/flink/table/plan/stats/TableStatsTest.java
Outdated
Show resolved
Hide resolved
...nner/src/main/java/org/apache/flink/table/planner/utils/CatalogTableStatisticsConverter.java
Outdated
Show resolved
Hide resolved
...la/org/apache/flink/table/planner/plan/optimize/program/FlinkRecomputeStatisticsProgram.java
Outdated
Show resolved
Hide resolved
...ink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java
Show resolved
Hide resolved
…ead of sum of all partitions when getting partition table column stats
…e partition column
031eff8 to
690ae2f
Compare
godfreyhe
approved these changes
Aug 22, 2022
Contributor
godfreyhe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, LGTM
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…ead of sum of all partitions when getting partition table column stats This closes apache#20595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Now, when we obtain column statistics
Ndvof the partition table, we use the method of taking sum ofNdvof all partitions, which will cause the obtained stats to be far from the real stats. So now we take the max value instead of sum of all partitions.Brief change log
Ndvtakes the max value instead of sum of all partitions when getting partition table column stats.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation