Skip to content

Conversation

@swuferhong
Copy link
Contributor

What is the purpose of the change

Now, when we obtain column statistics Ndv of the partition table, we use the method of taking sum of Ndv of all partitions, which will cause the obtained stats to be far from the real stats. So now we take the max value instead of sum of all partitions.

Brief change log

  • Change Ndv takes the max value instead of sum of all partitions when getting partition table column stats.
  • Modify related test.

Verifying this change

  • Modify related test.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? no

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 16, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@swuferhong
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left a few comments

Copy link
Contributor

@godfreyhe godfreyhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM

@godfreyhe godfreyhe closed this in 10e4c82 Aug 22, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…ead of sum of all partitions when getting partition table column stats

This closes apache#20595
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants