[FLINK-28997][datadog] Add switch to use logical identifier #20598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mas-chen
reviewed
Aug 16, 2022
...trics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporterFactory.java
Show resolved
Hide resolved
...trics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporterFactory.java
Show resolved
Hide resolved
alpinegizmo
reviewed
Aug 16, 2022
mas-chen
reviewed
Aug 17, 2022
Contributor
Author
|
@flinkbot run azure |
mas-chen
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a switch to the datadog reporter to use a logical identifier, so that variables aren't reported in a redundant fashion both as tags and as part of the metric identifier.
Before:
job.MyJobName.task.MyTask.metric:[job_name=MyJobName;task_name=MyTask]After:
job.task.metric:[job_name=MyJobName;task_name=MyTask]This was manually verified since we can't test the actual datadog integration offline.