Skip to content

Conversation

@jlon
Copy link
Contributor

@jlon jlon commented Aug 17, 2022

What is the purpose of the change

PyFlink supports specifying index-url when installing third-party dependencies。
When we use pyflink, if there is a third-party dependency, when using pip to install the package, it is retrieved and obtained from pypi.python.org by default, which is greatly affected by the network, slow download speed and easy to cause connection timeout. At this point, we think we can specify the index-url.

Brief change log

  • Supports specifying index-url through the parameter python.requirements.index-url when we install third-party dependencies.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (docs)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 17, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@jlon jlon force-pushed the FLINK-29004 branch 2 times, most recently from 3fb6317 to 3ad4107 Compare August 17, 2022 07:41
@jlon jlon changed the title PyFlink supports specifying index-url when installing third-party dependencies [FLINK-29004]PyFlink supports specifying index-url when installing third-party dependencies Aug 17, 2022
@Vancior
Copy link
Contributor

Vancior commented Aug 23, 2022

Thanks a lot for the PR! Could you add a simple test to verify it, like what it does for other requirement configurations?
BTW, PR merging will available right after code freeze for release-1.16.

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 15, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants