[FLINK-29007][e2e] Fix UsingRemoteJarITCase failed with NPE in hadoop3 #20613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
|
Please explain the change, and document the reasoning with a comment. |
zentol
reviewed
Aug 17, 2022
Contributor
Author
|
@zentol Thanks for review, I've updated it. |
zentol
reviewed
Aug 17, 2022
| <exclusions> | ||
| <exclusion> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-annotations</artifactId> |
Contributor
There was a problem hiding this comment.
Why is this being excluded?
Contributor
Author
There was a problem hiding this comment.
I print mvn dependency in hadoop2.8.5, found jackson-annotations is not included in hadoop-hdfs-client, but it existed in hadoop3, so I exclude it to keep consistency.
Contributor
There was a problem hiding this comment.
I'm not sure if that's a good idea. At the end of the day hadoop 3 has a different dependency tree, and trying to keep the close may just cause problems in the future when something suddenly stops working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix UsingRemoteJarITCase failed in hadoop3, test passed in local machine.
This change aim to address the ClassNotFoundException of
HdfsConfigurationwhen run test with hadoop3, the reason is that hadoop-hdfs module doesn't include transitive dependency of hadoop-hdfs-client, hadoop-hdfs-client is not in classpath, so we need to introduce this dependency explicitly in maven.Verifying this change
This change is already covered by existing tests in
UsingRemoteJarITCase.