Skip to content

Conversation

@xuyangzhong
Copy link
Contributor

What is the purpose of the change

Currently, we rewrite calcite to full its logic on Flink. But in connector-jdbc pom.xml, the wrong order about "flink-table-planner" and "flink-table-planner" (test-jar) will cause idea to fail when running MySqlCatalogITCase. This reason is that the wrong order causes idea to load calcite-1.26 first and then load table-planner, and the rewritten files do not work actually.

BTW, compiling and testing by maven, and other pom.xml will not be affected.

Brief change log

  • change dependency order about "flink-table-planner" and "flink-table-planner" (test-jar).

Verifying this change

This change is already covered by existing tests 'MySqlCatalogITCase'

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 23, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lsyldliu lsyldliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuyangzhong for the improvement, could you explain why test-jar will influence the dependency load order?

@leonardBang leonardBang merged commit d55be68 into apache:master Aug 31, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants