Skip to content

Conversation

@pltbkd
Copy link
Contributor

@pltbkd pltbkd commented Aug 26, 2022

What is the purpose of the change

This pull request picks the fixes of Flink-26394 and FLINK-27148 to release-1.13, since users using cdc sources on Flink 1.13 may also face the issue.

Brief change log

  • [FLINK-26394] Cancel the checkpoint completable future when checkpoint is aborting.
  • [FLINK-27148] Skip snapshotting the coordinators state or the master state if the pending checkpoint has been disposed.

Verifying this change

This change added tests and can be verified by running the newly added test case.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

pltbkd added 2 commits August 25, 2022 17:07
…en checkpoint is aborting.

(cherry picked from commit 31222b9)
… the master state if the pending checkpoint has been disposed.

This closes apache#19464.

(cherry picked from commit 2c608b8)
@pltbkd
Copy link
Contributor Author

pltbkd commented Aug 26, 2022

@flinkbot run azure

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 26, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@pltbkd
Copy link
Contributor Author

pltbkd commented Aug 26, 2022

@flinkbot run azure

@pltbkd
Copy link
Contributor Author

pltbkd commented Aug 26, 2022

@flinkbot run azure

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 180 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 15, 2025
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants