-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-28429][python] Optimize PyFlink tests #20685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d726f05 to
d32c4e1
Compare
|
@flinkbot run azure |
|
This doesn't seem to have the desired effect; the runtime of flink-python is still 51m, like on master. :( |
|
Due to the different performance of machines in the Azure, there is actually a deviation of about 30~40 minutes at most. Sometimes, the test time on the master can be exceed to 1.5 hours. As a whole, the average test time of running three versions of Python can be controlled within 2 hours, which can effectively avoid the situation that the nightly test exceeds 4 hours https://dev.azure.com/hxbks2ks/FLINK-TEST/_build/results?buildId=2036&view=logs&j=fba17979-6d2e-591d-72f1-97cf42797c11 . However, I will try again to see if the test time can be controlled within 30 minutes, so as to deal with the situation of timeout after more tests added in the future. The longer the test time of this release than last release is due to many new tests are added. |
d32c4e1 to
ab14fa6
Compare
|
@flinkbot run azure |
1 similar comment
|
@flinkbot run azure |
dianfu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HuangXingBo Nice work! Have left a few minor comments.
| fastavro>=1.1.0,<1.4.8 | ||
| grpcio>=1.29.0,<1.47 | ||
| grpcio-tools>=1.3.5,<=1.14.2 | ||
| grpcio-tools>=1.29.0,<=1.46.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to keep the version limit consistent between grpcio and grpcio-tools? That's either >=1.29.0,<1.47 or >=1.29.0,<1.46.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Make sense.
| * Starts a Flink mini cluster as a resource and registers the respective | ||
| * StreamExecutionEnvironment. | ||
| */ | ||
| public class MiniClusterWithClientResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not reuse the MiniClusterWithClientResource defined in flink-test-utils module?
ab14fa6 to
553427a
Compare
|
Hi, doesn't this commit introduce a bug? I've tried to setup from flink release-1.16 branch and found that the changes in Am I missing something here? |
What is the purpose of the change
This pull request will optimize PyFlink tests
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation