Skip to content

[BK-1.15][FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized #20699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tisonkun merged 1 commit into from
Aug 30, 2022
Merged

[BK-1.15][FLINK-28609][Connector/Pulsar] PulsarSchema didn't get properly serialized #20699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...or-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.flink.connector.pulsar.common.schema;

import org.apache.flink.annotation.Internal;
import org.apache.flink.util.IOUtils;

import org.apache.pulsar.client.api.Schema;
import org.apache.pulsar.client.impl.schema.SchemaInfoImpl;
Expand Down Expand Up @@ -163,8 +164,7 @@ private void readObject(ObjectInputStream ois) throws ClassNotFoundException, IO
// Schema
int byteLen = ois.readInt();
byte[] schemaBytes = new byte[byteLen];
int read = ois.read(schemaBytes);
checkState(read == byteLen);
IOUtils.readFully(ois, schemaBytes, 0, byteLen);

// Type
int typeIdx = ois.readInt();
Expand Down
28 changes: 28 additions & 0 deletions ...ulsar/src/test/java/org/apache/flink/connector/pulsar/common/schema/PulsarSchemaTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
import org.apache.pulsar.common.schema.SchemaType;
import org.junit.jupiter.api.Test;

import java.io.Serializable;

import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
Expand Down Expand Up @@ -117,9 +119,35 @@ void pulsarSchemaSerialization() throws Exception {
assertPulsarSchemaIsSerializable(new PulsarSchema<>(KV, Foo.class, FA.class));
}

@Test
void largeAvroSchemaSerialization() throws Exception {
Schema<LargeMessage> largeMessageSchema = Schema.AVRO(LargeMessage.class);
assertPulsarSchemaIsSerializable(
new PulsarSchema<>(largeMessageSchema, LargeMessage.class));
}

private <T> void assertPulsarSchemaIsSerializable(PulsarSchema<T> schema) throws Exception {
PulsarSchema<T> clonedSchema = InstantiationUtil.clone(schema);
assertEquals(clonedSchema.getSchemaInfo(), schema.getSchemaInfo());
assertEquals(clonedSchema.getRecordClass(), schema.getRecordClass());
}

/** A POJO Class which would generate a large schema by Avro. */
public static class LargeMessage implements Serializable {
private static final long serialVersionUID = 5364494369740402518L;

public String
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;
public String
bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;
public String
cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc;
public String
dddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd;
public String
eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee;
// the problem begins
public String
ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff;
}
}