[FLINK-28520][runtime] RestClient doesn't use SNI TLS extension #20808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jd-hatzenbuhler
changed the title
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
from
9b87914 to
68e013e
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
from
68e013e to
2830789
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
5 times, most recently
from
e4ea2cb to
2d54c4c
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
5 times, most recently
from
e2af8df to
0997524
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
2 times, most recently
from
6b4a9d5 to
7ccbf55
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
3 times, most recently
from
2d2134b to
ff64ef0
Compare
Author
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
2 times, most recently
from
762072e to
d645f41
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
from
d645f41 to
009a1b9
Compare
jd-hatzenbuhler
force-pushed
the
fix/FLINK-28520
branch
from
009a1b9 to
f32e97c
Compare
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| /** Ssl cases for {@link RestClient} and {@link RestServerEndpoint}. */ | ||
| public class RestClientSslTest extends TestLogger { |
Contributor
There was a problem hiding this comment.
This is an integration test.
|
|
||
| private static String sniHostReceived; | ||
|
|
||
| static { |
Contributor
There was a problem hiding this comment.
This static magic can have serious effect on other tests so just must be solved in a different way.
|
|
||
| /** Name Service to add fake DNS entry. */ | ||
| @SuppressWarnings("restriction") | ||
| public static class LocalHostNameService implements sun.net.spi.nameservice.NameService { |
Contributor
There was a problem hiding this comment.
Does sun.net.spi.nameservice.NameService exists in IBM JVM for portability?
|
|
||
| final SSLHandlerFactory sslHandlerFactory = restConfiguration.getSslHandlerFactory(); | ||
| ChannelInitializer<SocketChannel> initializer = | ||
| new ChannelInitializer<SocketChannel>() { |
Contributor
There was a problem hiding this comment.
Creating a new ChannelInitializer per request sound like perf degradation. Have you measured how much?
| } | ||
| } | ||
| }; | ||
| bootstrap.handler(initializer); |
Contributor
There was a problem hiding this comment.
Is this function not called from multiple threads? Now we introduce race here...
Author
|
Not needed anymore for our use case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request makes the RestClient us of the TLS SNI extension
Brief change log
The RestClient create the socket when the target Host and Port is known instead of during instanciation.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation