[FLINK-29274][hive] Fix ObjectStore leak when different users has dif… #20887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yuzelin
approved these changes
Sep 23, 2022
Contributor
yuzelin
left a comment
yuzelin
left a comment
There was a problem hiding this comment.
LGTM. I left several comments, please check out.
| // Trigger the creation of the HiveMetaStoreClient to use the same HiveConf. If the | ||
| // initial HiveConf is different, it will trigger the PersistenceManagerFactory to close | ||
| // all the alive PersistenceManager in the ObjectStore, which may get error like | ||
| // "PersistenceManager is closed" in the later connection. |
Contributor
There was a problem hiding this comment.
The exact exception message is “Persistence Manager has been closed”
| .setDefaultCatalog(catalogName) | ||
| .addSessionConfig(sessionConfig) | ||
| .build()); | ||
| // set variables to HiveConf or Session's conf |
Contributor
There was a problem hiding this comment.
I think this comment line (329) should lay before line 315 0r 319.
Member
Author
|
Thanks for your review. Because the comment is not releated to the code, I will this offline. |
Member
Author
|
The failed test is not releated to the fix. Merging... |
fsk119
changed the title
fsk119
added a commit
that referenced
this pull request
Sep 23, 2022
…ferent config This closes #20887
fsk119
added a commit
to fsk119/flink
that referenced
this pull request
Sep 23, 2022
…ferent config This closes apache#20887
fsk119
added a commit
to fsk119/flink
that referenced
this pull request
Sep 26, 2022
This closes apache#20887
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ferent config
What is the purpose of the change
The connection may leak when users have different config. Here, we fix this like hive does to use the same config to create the HiveMetaStoreClient.