Skip to content

Conversation

@snuyanzin
Copy link
Contributor

@snuyanzin snuyanzin commented Sep 27, 2022

What is the purpose of the change

SqlDotOperator, SqlItemOperator, AliasNamespace were introduced as copies from Calcite and with a fix inside at #12649
At the same side the fixed was applied in Calcite itself in 1.24. https://issues.apache.org/jira/browse/CALCITE-4085

Since now Flink depends on 1.26 the fix is included and there is no need to have these classes in Flink repo

Brief change log

  • flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlDotOperator.java
  • flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java
  • flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/AliasNamespace.java

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
  • The S3 file system connector: (no )

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin changed the title [DRAFT] Remove Calcite classes since they were fixed in 1.24 [FLINK-29446][Table SQL/API] Remove Calcite classes since they were fixed in 1.24 Sep 28, 2022
@snuyanzin snuyanzin marked this pull request as ready for review September 28, 2022 09:14
@snuyanzin
Copy link
Contributor Author

@twalthr could you please have a look once you have time?
It looks like for some reason these classes were not removed during update to 1.24+

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snuyanzin! LGTM.

@twalthr twalthr closed this in 90f4239 Oct 11, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants