Skip to content

Conversation

@reswqa
Copy link
Member

@reswqa reswqa commented Sep 29, 2022

What is the purpose of the change

HsResultPartitionTest.testRelease failed with AssertionFailedError. This is caused by FLINK-29425, it changes the conditions for spilling, which may cause some buffers to be released during the test.

Brief change log

  • Set FullStrategyNumBuffersTriggerSpillingRatio and FullStrategyReleaseBufferRatio manually.

Verifying this change

This change fixes unstable test HsResultPartitionTest.testRelease.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

This is caused by FLINK-29425, it changes the conditions for spilling, which may cause some buffers to be released during the test.
@reswqa
Copy link
Member Author

reswqa commented Sep 29, 2022

@flinkbot run azure

xintongsong pushed a commit that referenced this pull request Sep 30, 2022
This is caused by FLINK-29425, it changes the conditions for spilling, which may cause some buffers to be released during the test.

This closes #20918
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
This is caused by FLINK-29425, it changes the conditions for spilling, which may cause some buffers to be released during the test.

This closes apache#20918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants