[FLINK-3395] [build] Make test utils properly available and fix Maven dependencies #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the JUnit test utils (TestLogger, retry rules, ...) properly available to other projects without the 'flink-core' test-jar, via the 'flink-test-utils-junit' project. Makes the ForkableMiniCluster, TestEnvironment, and other test utilities available in the 'main' scope of the 'flink-test-utils' project. Creates a 'flink-test-utils-parent' project that holds the 'flink-test-utils-junit' and 'flink-test-utils' project. Also moves some tests between projects and inlines some very simple utility functions in order to simplify some test jar dependencies.
…t utilities. Test utilities include the StreamingMultipleProgramsTestBase and StreamingTestEnvironment. This moves the ITCases for streaming into 'flink-tests' to achieve that.
| <dependency> | ||
| <groupId>org.apache.flink</groupId> | ||
| <artifactId>flink-streaming-scala_2.10</artifactId> | ||
| <version>1.1-SNAPSHOT</version> |
Contributor
There was a problem hiding this comment.
Oh wow. This is really bad.
Contributor
|
I quickly looked through the changed files. I think the changes are okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests fixes maven project scopes:
ForkableMiniCluster,TestEnvironment, ...) should not be in test-jars, but in reusable and user-exposed test utils projects in main scope.New Structure
TestLoggerRetryRulesThis reduces the
flink-coretest-jardependency.ForkableMiniClusterTestEnvironment&TestStreamEnvironmentMultipleProgramsTestBase&StreamingMultipleProgramsTestBaseflink-test-utils-junitandflink-test-utilsare in the parent projectflink-test-utils-parent.Tons of tests have minor adjustments to use different ways of accessing a specific test utility function, to keep the dependencies smaller.
Other Fixes
The size of this pull request is very large, but most edits are straightforward minor changes due to moving certain util classes and consolidating duplicate util classes.