[FLINK-29487][rpc] RpcService extends AutoCloseableAsync #20932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
XComp
approved these changes
Oct 4, 2022
| CompletableFuture<Void> terminationFuture = rpcEndpoint.getTerminationFuture(); | ||
|
|
||
| rpcService.stopService(); | ||
| rpcService.closeAsync(); |
Contributor
There was a problem hiding this comment.
A bit out-of-scope, but I'm wondering whether we should also assert the completion of the CompletableFuture that is returned by closeAsync here? ...just to be sure that the service has actually stopped properly after the completion of the terminationFuture succeeded. WDYT? 🤔
Contributor
Author
There was a problem hiding this comment.
AFAICT that's covered by AkkaRpcServiceTest#testAkkaRpcServiceShutDownWithRpcEndpoints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.