[FLINK-29508][legal] Improve detection of non-deployed modules that need a NOTICE #20966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
flink-fs-hadoop-shaded,flink-s3-fs-baseandflink-table-planner-loader-bundlenot being covered by license checks as they got auto-ignored due to not being deployed.The checker now only ignores non-deployed modules if they are not bundled by another deployed module.
Note that this approach will not work if a non-deployed module is bundled by another non-deployed module which is then bundled by a deployed module.
This is currently not a problem though.
I noticed this problem when I saw this in the CI output of a build, despite the NOTICE being correct:
What happened is that the NOTICE was still found, but we already threw out the information about bundles dependencies for that module.
We really need some tests for this...